feat(//core/converters): Add normalization plugin #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: conversion
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
There are some changes that do not conform to C++ style guidelines:
diff --git a/workspace/tests/core/conversion/converters/test_element_wise.cpp b/tmp/changes.txt
index 4b2fe9c..5431e9a 100644
--- a/workspace/tests/core/conversion/converters/test_element_wise.cpp
+++ b/tmp/changes.txt
@@ -172,117 +172,117 @@ TEST(Converters, ATenNeScalarConvertsCorrectly) {
pointwise_test_helper(graph, true, false, {3, 4, 2});
;
-TEST(Converters, ATenClampMinConvertsCorrectly) {
- const auto graph = R"IR(
+ TEST(Converters, ATenClampMinConvertsCorrectly) {
+ const auto graph = R"IR(
graph(%x.1 : Tensor):
%2 : int = prim::Constant[value=-2]()
%3 : None = prim::Constant()
%4 : Tensor = aten::clamp(%x.1, %2, %3)
return (%4))IR";
- pointwise_test_helper(graph, true);
-}
+ pointwise_test_helper(graph, true);
+ }
-TEST(Converters, ATenClampMaxConvertsCorrectly) {
- const auto graph = R"IR(
+ TEST(Converters, ATenClampMaxConvertsCorrectly) {
+ const auto graph = R"IR(
graph(%x.1 : Tensor):
%2 : int = prim::Constant[value=3]()
%3 : None = prim::Constant()
%4 : Tensor = aten::clamp(%x.1, %3, %2)
return (%4))IR";
- pointwise_test_helper(graph, true);
-}
+ pointwise_test_helper(graph, true);
+ }
-TEST(Converters, ATenClampMinMaxConvertsCorrectly) {
- const auto graph = R"IR(
+ TEST(Converters, ATenClampMinMaxConvertsCorrectly) {
+ const auto graph = R"IR(
graph(%x.1 : Tensor):
%2 : int = prim::Constant[value=3]()
%3 : int = prim::Constant[value=-2]()
%4 : Tensor = aten::clamp(%x.1, %3, %2)
return (%4))IR";
- pointwise_test_helper(graph, true);
-}
+ pointwise_test_helper(graph, true);
+ }
-TEST(Converters, ATenGreaterThanConvertsCorrectly) {
- const auto graph = R"IR(
+ TEST(Converters, ATenGreaterThanConvertsCorrectly) {
+ const auto graph = R"IR(
graph(%0 : Tensor, %1 : Tensor):
%2 : Tensor = aten::gt(%0, %1)
return (%2))IR";
- pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
-}
+ pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
+ }
-TEST(Converters, ATenGreaterThanScalarConvertsCorrectly) {
- const auto graph = R"IR(
+ TEST(Converters, ATenGreaterThanScalarConvertsCorrectly) {
+ const auto graph = R"IR(
graph(%0 : Tensor):
%scalar : float = prim::Constant[value=3]()
%2 : Tensor = aten::gt(%0, %scalar)
return (%2))IR";
- pointwise_test_helper(graph, true, false, {5, 5});
-}
+ pointwise_test_helper(graph, true, false, {5, 5});
+ }
-TEST(Converters, ATenLessThanConvertsCorrectly) {
- const auto graph = R"IR(
+ TEST(Converters, ATenLessThanConvertsCorrectly) {
+ const auto graph = R"IR(
graph(%0 : Tensor, %1 : Tensor):
%2 : Tensor = aten::lt(%0, %1)
return (%2))IR";
- pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
-}
+ pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
+ }
-TEST(Converters, ATenLessThanScalarConvertsCorrectly) {
- const auto graph = R"IR(
+ TEST(Converters, ATenLessThanScalarConvertsCorrectly) {
+ const auto graph = R"IR(
graph(%0 : Tensor):
%scalar : float = prim::Constant[value=3]()
%2 : Tensor = aten::lt(%0, %scalar)
return (%2))IR";
- pointwise_test_helper(graph, true, false, {5, 5});
-}
+ pointwise_test_helper(graph, true, false, {5, 5});
+ }
-TEST(Converters, ATenEqualConvertsCorrectly) {
- const auto graph = R"IR(
+ TEST(Converters, ATenEqualConvertsCorrectly) {
+ const auto graph = R"IR(
graph(%0 : Tensor, %1 : Tensor):
%2 : Tensor = aten::eq(%0, %1)
return (%2))IR";
- pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
-}
+ pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
+ }
-TEST(Converters, ATenEqualScalarConvertsCorrectly) {
- const auto graph = R"IR(
+ TEST(Converters, ATenEqualScalarConvertsCorrectly) {
+ const auto graph = R"IR(
graph(%0 : Tensor):
%scalar : float = prim::Constant[value=3]()
%2 : Tensor = aten::eq(%0, %scalar)
return (%2))IR";
- pointwise_test_helper(graph, true, false, {5, 5});
-}
+ pointwise_test_helper(graph, true, false, {5, 5});
+ }
-TEST(Converters, ATenGEConvertsCorrectly) {
- const auto graph = R"IR(
+ TEST(Converters, ATenGEConvertsCorrectly) {
+ const auto graph = R"IR(
graph(%0 : Tensor, %1 : Tensor):
%2 : Tensor = aten::ge(%0, %1)
return (%2))IR";
- pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
-}
+ pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
+ }
-TEST(Converters, ATenGEScalarConvertsCorrectly) {
- const auto graph = R"IR(
+ TEST(Converters, ATenGEScalarConvertsCorrectly) {
+ const auto graph = R"IR(
graph(%0 : Tensor):
%scalar : float = prim::Constant[value=3]()
%2 : Tensor = aten::ge(%0, %scalar)
return (%2))IR";
- pointwise_test_helper(graph, true, false, {5, 5});
-}
+ pointwise_test_helper(graph, true, false, {5, 5});
+ }
-TEST(Converters, ATenLEConvertsCorrectly) {
- const auto graph = R"IR(
+ TEST(Converters, ATenLEConvertsCorrectly) {
+ const auto graph = R"IR(
graph(%0 : Tensor, %1 : Tensor):
%2 : Tensor = aten::le(%0, %1)
return (%2))IR";
- pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
-}
+ pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
+ }
-TEST(Converters, ATenLEScalarConvertsCorrectly) {
- const auto graph = R"IR(
+ TEST(Converters, ATenLEScalarConvertsCorrectly) {
+ const auto graph = R"IR(
graph(%0 : Tensor):
%scalar : float = prim::Constant[value=3]()
%2 : Tensor = aten::le(%0, %scalar)
return (%2))IR";
- pointwise_test_helper(graph, true, false, {5, 5});
-}
+ pointwise_test_helper(graph, true, false, {5, 5});
+ }
ERROR: Some files do not conform to style guidelines
There was a problem hiding this comment.
There are some changes that do not conform to C++ style guidelines:
diff --git a/workspace/tests/core/conversion/converters/test_element_wise.cpp b/tmp/changes.txt
index 4b2fe9c..5431e9a 100644
--- a/workspace/tests/core/conversion/converters/test_element_wise.cpp
+++ b/tmp/changes.txt
@@ -172,117 +172,117 @@ TEST(Converters, ATenNeScalarConvertsCorrectly) {
pointwise_test_helper(graph, true, false, {3, 4, 2});
;
-TEST(Converters, ATenClampMinConvertsCorrectly) {
- const auto graph = R"IR(
+ TEST(Converters, ATenClampMinConvertsCorrectly) {
+ const auto graph = R"IR(
graph(%x.1 : Tensor):
%2 : int = prim::Constant[value=-2]()
%3 : None = prim::Constant()
%4 : Tensor = aten::clamp(%x.1, %2, %3)
return (%4))IR";
- pointwise_test_helper(graph, true);
-}
+ pointwise_test_helper(graph, true);
+ }
-TEST(Converters, ATenClampMaxConvertsCorrectly) {
- const auto graph = R"IR(
+ TEST(Converters, ATenClampMaxConvertsCorrectly) {
+ const auto graph = R"IR(
graph(%x.1 : Tensor):
%2 : int = prim::Constant[value=3]()
%3 : None = prim::Constant()
%4 : Tensor = aten::clamp(%x.1, %3, %2)
return (%4))IR";
- pointwise_test_helper(graph, true);
-}
+ pointwise_test_helper(graph, true);
+ }
-TEST(Converters, ATenClampMinMaxConvertsCorrectly) {
- const auto graph = R"IR(
+ TEST(Converters, ATenClampMinMaxConvertsCorrectly) {
+ const auto graph = R"IR(
graph(%x.1 : Tensor):
%2 : int = prim::Constant[value=3]()
%3 : int = prim::Constant[value=-2]()
%4 : Tensor = aten::clamp(%x.1, %3, %2)
return (%4))IR";
- pointwise_test_helper(graph, true);
-}
+ pointwise_test_helper(graph, true);
+ }
-TEST(Converters, ATenGreaterThanConvertsCorrectly) {
- const auto graph = R"IR(
+ TEST(Converters, ATenGreaterThanConvertsCorrectly) {
+ const auto graph = R"IR(
graph(%0 : Tensor, %1 : Tensor):
%2 : Tensor = aten::gt(%0, %1)
return (%2))IR";
- pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
-}
+ pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
+ }
-TEST(Converters, ATenGreaterThanScalarConvertsCorrectly) {
- const auto graph = R"IR(
+ TEST(Converters, ATenGreaterThanScalarConvertsCorrectly) {
+ const auto graph = R"IR(
graph(%0 : Tensor):
%scalar : float = prim::Constant[value=3]()
%2 : Tensor = aten::gt(%0, %scalar)
return (%2))IR";
- pointwise_test_helper(graph, true, false, {5, 5});
-}
+ pointwise_test_helper(graph, true, false, {5, 5});
+ }
-TEST(Converters, ATenLessThanConvertsCorrectly) {
- const auto graph = R"IR(
+ TEST(Converters, ATenLessThanConvertsCorrectly) {
+ const auto graph = R"IR(
graph(%0 : Tensor, %1 : Tensor):
%2 : Tensor = aten::lt(%0, %1)
return (%2))IR";
- pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
-}
+ pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
+ }
-TEST(Converters, ATenLessThanScalarConvertsCorrectly) {
- const auto graph = R"IR(
+ TEST(Converters, ATenLessThanScalarConvertsCorrectly) {
+ const auto graph = R"IR(
graph(%0 : Tensor):
%scalar : float = prim::Constant[value=3]()
%2 : Tensor = aten::lt(%0, %scalar)
return (%2))IR";
- pointwise_test_helper(graph, true, false, {5, 5});
-}
+ pointwise_test_helper(graph, true, false, {5, 5});
+ }
-TEST(Converters, ATenEqualConvertsCorrectly) {
- const auto graph = R"IR(
+ TEST(Converters, ATenEqualConvertsCorrectly) {
+ const auto graph = R"IR(
graph(%0 : Tensor, %1 : Tensor):
%2 : Tensor = aten::eq(%0, %1)
return (%2))IR";
- pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
-}
+ pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
+ }
-TEST(Converters, ATenEqualScalarConvertsCorrectly) {
- const auto graph = R"IR(
+ TEST(Converters, ATenEqualScalarConvertsCorrectly) {
+ const auto graph = R"IR(
graph(%0 : Tensor):
%scalar : float = prim::Constant[value=3]()
%2 : Tensor = aten::eq(%0, %scalar)
return (%2))IR";
- pointwise_test_helper(graph, true, false, {5, 5});
-}
+ pointwise_test_helper(graph, true, false, {5, 5});
+ }
-TEST(Converters, ATenGEConvertsCorrectly) {
- const auto graph = R"IR(
+ TEST(Converters, ATenGEConvertsCorrectly) {
+ const auto graph = R"IR(
graph(%0 : Tensor, %1 : Tensor):
%2 : Tensor = aten::ge(%0, %1)
return (%2))IR";
- pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
-}
+ pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
+ }
-TEST(Converters, ATenGEScalarConvertsCorrectly) {
- const auto graph = R"IR(
+ TEST(Converters, ATenGEScalarConvertsCorrectly) {
+ const auto graph = R"IR(
graph(%0 : Tensor):
%scalar : float = prim::Constant[value=3]()
%2 : Tensor = aten::ge(%0, %scalar)
return (%2))IR";
- pointwise_test_helper(graph, true, false, {5, 5});
-}
+ pointwise_test_helper(graph, true, false, {5, 5});
+ }
-TEST(Converters, ATenLEConvertsCorrectly) {
- const auto graph = R"IR(
+ TEST(Converters, ATenLEConvertsCorrectly) {
+ const auto graph = R"IR(
graph(%0 : Tensor, %1 : Tensor):
%2 : Tensor = aten::le(%0, %1)
return (%2))IR";
- pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
-}
+ pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
+ }
-TEST(Converters, ATenLEScalarConvertsCorrectly) {
- const auto graph = R"IR(
+ TEST(Converters, ATenLEScalarConvertsCorrectly) {
+ const auto graph = R"IR(
graph(%0 : Tensor):
%scalar : float = prim::Constant[value=3]()
%2 : Tensor = aten::le(%0, %scalar)
return (%2))IR";
- pointwise_test_helper(graph, true, false, {5, 5});
-}
+ pointwise_test_helper(graph, true, false, {5, 5});
+ }
ERROR: Some files do not conform to style guidelines
narendasan
added
the
on hold
|
handled in #425 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add normalization plugin. This plugin currently uses pytorch aten library kernels.
Fixes #280
Type of change
Checklist: